apollo/spruce
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity Actions

refactor: add golangci-lint plus more code refactoring #8

Manually merged
dananglin merged 0 commits from golangci-lint into main 2023-08-21 03:13:01 +01:00
Conversation 0 Commits - Files changed -
dananglin commented 2023-08-21 03:03:52 +01:00
Owner
Copy link

Add golangci-lint for linting and refactor the code based on the feedback from running it.

Changes:

  • Add configuration for golangci-lint.
  • Break the large function in create.go into smaller ones.
  • Rename internal/templateFuncs to internal/templatefuncs to remove the upper case letters in package name.
  • Add a mage target for lint tests.
Add `golangci-lint` for linting and refactor the code based on the feedback from running it. Changes: - Add configuration for `golangci-lint`. - Break the large function in create.go into smaller ones. - Rename `internal/templateFuncs` to `internal/templatefuncs` to remove the upper case letters in package name. - Add a mage target for lint tests.
dananglin force-pushed golangci-lint from 6e462347af to 71d62ecaf6 2023-08-21 03:10:48 +01:00 Compare
dananglin changed title from refactor: add golangci-lint + more code refactoring to refactor: add golangci-lint plus more code refactoring 2023-08-21 03:11:08 +01:00
dananglin manually merged commit 71d62ecaf6 into main 2023-08-21 03:13:01 +01:00
dananglin deleted branch golangci-lint 2023-08-21 03:13:20 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: apollo/spruce#8
No description provided.
Delete branch "golangci-lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?