apollo/enbas
1
0
Fork 0
Code Issues 4 Pull requests Projects Activity Actions

refactor: updated the executor lookup table #57

Manually merged
dananglin merged 1 commit from remove-the-executor-interface into main 2024-08-22 01:56:17 +01:00
Conversation 0 Commits 1 Files changed 8 +1572 -1112
dananglin commented 2024-08-21 14:50:05 +01:00
Owner
Copy link

Updated the executor map by changing the map type from map[string]Executor to map[string]func(string, bool, []string) error in order to reduce the cost of initialising the map. Previously the map initialised all executors and only ran the executor called by the command, now the map maps the command to the function of type func(string, bool, []string) error that will initialise and run the single executor called by the command. As a result the Executor interface is no longer needed and has been removed.

Updated the executor map by changing the map type from `map[string]Executor` to `map[string]func(string, bool, []string) error` in order to reduce the cost of initialising the map. Previously the map initialised all executors and only ran the executor called by the command, now the map maps the command to the function of type `func(string, bool, []string) error` that will initialise and run the single executor called by the command. As a result the `Executor` interface is no longer needed and has been removed.
dananglin added 3 commits 2024-08-21 14:50:06 +01:00
small edit
All checks were successful
Tests / test (pull_request) Successful in 18s
Details
49b734f925
dananglin added 1 commit 2024-08-21 18:35:50 +01:00
dananglin force-pushed remove-the-executor-interface from 4f85a4454b to 89e53bcc9f 2024-08-21 18:48:39 +01:00 Compare
dananglin added this to the v0.2.0 milestone 2024-08-21 18:51:01 +01:00
dananglin manually merged commit 89e53bcc9f into main 2024-08-22 01:56:17 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
v0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: apollo/enbas#57
No description provided.
Delete branch "remove-the-executor-interface"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?