apollo/enbas
1
0
Fork 0
Code Issues 4 Pull requests Projects Activity Actions

feat(BREAKING): new parser for the time duration value #55

Manually merged
dananglin merged 1 commit from custom-time-duration-parser into main 2024-08-20 03:41:47 +01:00
Conversation 0 Commits 1 Files changed 7 +213 -34
dananglin commented 2024-08-19 23:20:30 +01:00
Owner
Copy link

This PR adds a new parser for the time duration flag value type. Previously this used the parser from the time package but this was limited to parsing units of time up to hours. The new parser allows users to specify days, hours, minutes and seconds and is quite flexible with how users format their string inputs.

This PR adds a new parser for the time duration flag value type. Previously this used the [parser](https://pkg.go.dev/time#ParseDuration) from the time package but this was limited to parsing units of time up to `hours`. The new parser allows users to specify days, hours, minutes and seconds and is quite flexible with how users format their string inputs.
dananglin added this to the v0.2.0 milestone 2024-08-19 23:20:30 +01:00
dananglin added 3 commits 2024-08-19 23:20:31 +01:00
update documentation
All checks were successful
Tests / test (pull_request) Successful in 19s
Details
72caa3efb4
dananglin added 1 commit 2024-08-20 00:08:05 +01:00
dananglin force-pushed custom-time-duration-parser from ced5a4e6eb to 22c654c9b1 2024-08-20 01:01:43 +01:00 Compare
dananglin added 1 commit 2024-08-20 03:20:05 +01:00
update flag unit tests
All checks were successful
Tests / test (pull_request) Successful in 21s
Details
e555e0cb7d
dananglin force-pushed custom-time-duration-parser from e555e0cb7d to 0ad02e0af4 2024-08-20 03:39:59 +01:00 Compare
dananglin manually merged commit 0ad02e0af4 into main 2024-08-20 03:41:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
v0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: apollo/enbas#55
No description provided.
Delete branch "custom-time-duration-parser"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?